37 lines
1.2 KiB
Diff
37 lines
1.2 KiB
Diff
|
From cd2729e49d14b8f8411a9c39312ff60bc7200f8a Mon Sep 17 00:00:00 2001
|
||
|
|
From: Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>
|
||
|
|
Date: Tue, 21 Feb 2023 11:14:26 +0000
|
||
|
|
Subject: [PATCH] net/af_xdp: fix socket handler validation
|
||
|
|
|
||
|
|
[ upstream commit cd2729e49d14b8f8411a9c39312ff60bc7200f8a ]
|
||
|
|
|
||
|
|
Fix integer handling issues (NEGATIVE_RETURNS) reported
|
||
|
|
in coverity scan. Add a check to sock variable if the
|
||
|
|
value is negative return -1.
|
||
|
|
|
||
|
|
Coverity issue: 383245
|
||
|
|
Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration")
|
||
|
|
|
||
|
|
Signed-off-by: Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>
|
||
|
|
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
|
||
|
|
---
|
||
|
|
drivers/net/af_xdp/rte_eth_af_xdp.c | 2 ++
|
||
|
|
1 file changed, 2 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
|
||
|
|
index 02c874d51e..2a20a6960c 100644
|
||
|
|
--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
|
||
|
|
+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
|
||
|
|
@@ -1508,6 +1508,8 @@ get_cni_fd(char *if_name)
|
||
|
|
|
||
|
|
memset(&server, 0, sizeof(server));
|
||
|
|
sock = init_uds_sock(&server);
|
||
|
|
+ if (sock < 0)
|
||
|
|
+ return -1;
|
||
|
|
|
||
|
|
/* Initiates handshake to CNI send: /connect,hostname */
|
||
|
|
snprintf(request, sizeof(request), "%s,%s", UDS_CONNECT_MSG, hostname);
|
||
|
|
--
|
||
|
|
2.33.0
|
||
|
|
|