37 lines
1.3 KiB
Diff
37 lines
1.3 KiB
Diff
From 474eb62d85b65de1f4a9389d28e4a380a0bf1d7b Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
|
|
Date: Wed, 9 Oct 2024 11:52:52 -0400
|
|
Subject: [PATCH] matroskademux: Put a copy of the codec data into the A_MS/ACM
|
|
caps
|
|
|
|
The original codec data buffer is owned by matroskademux and does not
|
|
necessarily live as long as the caps.
|
|
|
|
Thanks to Antonio Morales for finding and reporting the issue.
|
|
|
|
Fixes GHSL-2024-280
|
|
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3894
|
|
|
|
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8057>
|
|
---
|
|
gst/matroska/matroska-demux.c | 3 +--
|
|
1 file changed, 1 insertion(+), 2 deletions(-)
|
|
|
|
diff --git a/gst/matroska/matroska-demux.c b/gst/matroska/matroska-demux.c
|
|
index a35f79f02381..afde4ee62897 100644
|
|
--- a/gst/matroska/matroska-demux.c
|
|
+++ b/gst/matroska/matroska-demux.c
|
|
@@ -7183,8 +7183,7 @@ gst_matroska_demux_audio_caps (GstMatroskaTrackAudioContext *
|
|
|
|
/* 18 is the waveformatex size */
|
|
if (size > 18) {
|
|
- codec_data = gst_buffer_new_wrapped_full (GST_MEMORY_FLAG_READONLY,
|
|
- data + 18, size - 18, 0, size - 18, NULL, NULL);
|
|
+ codec_data = gst_buffer_new_memdup (data + 18, size - 18);
|
|
}
|
|
|
|
if (riff_audio_fmt)
|
|
--
|
|
GitLab
|
|
|