Compare commits
No commits in common. "3a2238018117e9e0af1ee329e06688c100033738" and "bd6b41a3306db42d378ea70f97bc22f68243f8a2" have entirely different histories.
3a22380181
...
bd6b41a330
@ -1,58 +0,0 @@
|
|||||||
From 65977c33a6735b0ffc7d2c691243452f75c1f68c Mon Sep 17 00:00:00 2001
|
|
||||||
From: Olivier Fourdan <ofourdan@redhat.com>
|
|
||||||
Date: Wed, 27 Nov 2024 14:41:45 +0100
|
|
||||||
Subject: [PATCH] xkb: Fix buffer overflow in XkbVModMaskText()
|
|
||||||
|
|
||||||
The code in XkbVModMaskText() allocates a fixed sized buffer on the
|
|
||||||
stack and copies the virtual mod name.
|
|
||||||
|
|
||||||
There's actually two issues in the code that can lead to a buffer
|
|
||||||
overflow.
|
|
||||||
|
|
||||||
First, the bound check mixes pointers and integers using misplaced
|
|
||||||
parenthesis, defeating the bound check.
|
|
||||||
|
|
||||||
But even though, if the check fails, the data is still copied, so the
|
|
||||||
stack overflow will occur regardless.
|
|
||||||
|
|
||||||
Change the logic to skip the copy entirely if the bound check fails.
|
|
||||||
|
|
||||||
(cherry picked from xorg/xserver@11fcda8753e994e15eb915d28cf487660ec8e722)
|
|
||||||
|
|
||||||
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
|
|
||||||
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
|
|
||||||
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
||||||
---
|
|
||||||
src/xkbtext.c | 16 ++++++++--------
|
|
||||||
1 file changed, 8 insertions(+), 8 deletions(-)
|
|
||||||
|
|
||||||
diff --git a/src/xkbtext.c b/src/xkbtext.c
|
|
||||||
index 4459ca7..59429b2 100644
|
|
||||||
--- a/src/xkbtext.c
|
|
||||||
+++ b/src/xkbtext.c
|
|
||||||
@@ -190,14 +190,14 @@ XkbVModMaskText(Display * dpy,
|
|
||||||
len = strlen(tmp) + 1 + (str == buf ? 0 : 1);
|
|
||||||
if (format == XkbCFile)
|
|
||||||
len += 4;
|
|
||||||
- if ((str - (buf + len)) <= BUFFER_SIZE) {
|
|
||||||
- if (str != buf) {
|
|
||||||
- if (format == XkbCFile)
|
|
||||||
- *str++ = '|';
|
|
||||||
- else
|
|
||||||
- *str++ = '+';
|
|
||||||
- len--;
|
|
||||||
- }
|
|
||||||
+ if ((str - buf) + len > BUFFER_SIZE)
|
|
||||||
+ continue; /* Skip */
|
|
||||||
+ if (str != buf) {
|
|
||||||
+ if (format == XkbCFile)
|
|
||||||
+ *str++ = '|';
|
|
||||||
+ else
|
|
||||||
+ *str++ = '+';
|
|
||||||
+ len--;
|
|
||||||
}
|
|
||||||
if (format == XkbCFile)
|
|
||||||
sprintf(str, "%sMask", tmp);
|
|
||||||
--
|
|
||||||
GitLab
|
|
||||||
|
|
||||||
@ -1,13 +1,11 @@
|
|||||||
Name: libxkbfile
|
Name: libxkbfile
|
||||||
Version: 1.1.0
|
Version: 1.1.0
|
||||||
Release: 6
|
Release: 1
|
||||||
Summary: X11 keyboard file manipulation library
|
Summary: X11 keyboard file manipulation library
|
||||||
License: MIT
|
License: MIT
|
||||||
URL: https://www.x.org
|
URL: https://www.x.org
|
||||||
Source0: https://www.x.org/releases/individual/lib/%{name}-%{version}.tar.bz2
|
Source0: https://www.x.org/releases/individual/lib/%{name}-%{version}.tar.bz2
|
||||||
|
|
||||||
Patch6000: backport-CVE-2025-26595.patch
|
|
||||||
|
|
||||||
BuildRequires: gcc xorg-x11-proto-devel libX11-devel
|
BuildRequires: gcc xorg-x11-proto-devel libX11-devel
|
||||||
|
|
||||||
%description
|
%description
|
||||||
@ -29,9 +27,6 @@ export CFLAGS="%{optflags} -fno-strict-aliasing"
|
|||||||
%configure
|
%configure
|
||||||
%make_build
|
%make_build
|
||||||
|
|
||||||
%check
|
|
||||||
make check
|
|
||||||
|
|
||||||
%install
|
%install
|
||||||
%make_install
|
%make_install
|
||||||
%delete_la_and_a
|
%delete_la_and_a
|
||||||
@ -40,8 +35,7 @@ make check
|
|||||||
|
|
||||||
%files
|
%files
|
||||||
%defattr(-,root,root)
|
%defattr(-,root,root)
|
||||||
%license COPYING
|
%doc ChangeLog COPYING
|
||||||
%doc ChangeLog
|
|
||||||
%{_libdir}/%{name}.so.*
|
%{_libdir}/%{name}.so.*
|
||||||
|
|
||||||
%files devel
|
%files devel
|
||||||
@ -51,24 +45,6 @@ make check
|
|||||||
%{_libdir}/%{name}.so
|
%{_libdir}/%{name}.so
|
||||||
|
|
||||||
%changelog
|
%changelog
|
||||||
* Thu Feb 27 2025 lingsheng <lingsheng1@h-partners.com> - 1.1.0-6
|
|
||||||
- fix CVE-2025-26595
|
|
||||||
|
|
||||||
* Wed Oct 26 2022 zhouwenpei <zhouwenpei1@h-partners.com> - 1.1.0-5
|
|
||||||
- Rebuild for next release
|
|
||||||
|
|
||||||
* Thu Feb 18 2021 jinzhimin <jinzhimin2@huawei.com> - 1.1.0-4
|
|
||||||
- rebuild libxkbfile
|
|
||||||
|
|
||||||
* Thu Feb 18 2021 jinzhimin <jinzhimin2@huawei.com> - 1.1.0-3
|
|
||||||
- add check in spec
|
|
||||||
|
|
||||||
* Mon Oct 21 2019 openEuler Buildteam <buildteam@openeuler.org> - 1.1.0-2
|
|
||||||
- Type:enhancement
|
|
||||||
- Id:NA
|
|
||||||
- SUG:NA
|
|
||||||
- DESC:modify the location of COPYING
|
|
||||||
|
|
||||||
* Fri Sep 6 2019 openEuler Buildteam <buildteam@openeuler.org> - 1.1.0-1
|
* Fri Sep 6 2019 openEuler Buildteam <buildteam@openeuler.org> - 1.1.0-1
|
||||||
- Type:enhancement
|
- Type:enhancement
|
||||||
- ID:NA
|
- ID:NA
|
||||||
|
|||||||
@ -1,5 +0,0 @@
|
|||||||
version_control: git
|
|
||||||
src_repo: https://gitlab.freedesktop.org/xorg/lib/libxmu.git
|
|
||||||
tag_prefix: libxkbfile-
|
|
||||||
seperator: "."
|
|
||||||
|
|
||||||
Loading…
x
Reference in New Issue
Block a user