49 lines
1.6 KiB
Diff
49 lines
1.6 KiB
Diff
|
From 743ade13f9b675b4a5aa8631235d681fd66ee854 Mon Sep 17 00:00:00 2001
|
||
|
|
From: zhujun2 <zhujun2_yewu@cmss.chinamobile.com>
|
||
|
|
Date: Thu, 11 Apr 2024 00:53:25 -0700
|
||
|
|
Subject: [PATCH] tulip: Remove unused variable
|
||
|
|
|
||
|
|
Variable n used in tulip_idblock_crc function is only incremented but never read.
|
||
|
|
This causes 'Unused but set variable' warning on Clang 15.0.1 compiler.
|
||
|
|
|
||
|
|
Removing the variable to prevent the warning.
|
||
|
|
|
||
|
|
Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
|
||
|
|
Reviewed-by: Thomas Huth <thuth@redhat.com>
|
||
|
|
Message-Id: <02e1560d115c208df32236df8916fed98429fda1.1668009030.git.mrezanin@redhat.com>
|
||
|
|
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
||
|
|
(cherry picked from commit 6083dcad80743718620a3f8a72fb76ea8b7c28ca)
|
||
|
|
Signed-off-by: zhujun2 <zhujun2_yewu@cmss.chinamobile.com>
|
||
|
|
---
|
||
|
|
hw/net/tulip.c | 4 +---
|
||
|
|
1 file changed, 1 insertion(+), 3 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/hw/net/tulip.c b/hw/net/tulip.c
|
||
|
|
index d319f9fb80..956093abd7 100644
|
||
|
|
--- a/hw/net/tulip.c
|
||
|
|
+++ b/hw/net/tulip.c
|
||
|
|
@@ -870,11 +870,10 @@ static const MemoryRegionOps tulip_ops = {
|
||
|
|
|
||
|
|
static void tulip_idblock_crc(TULIPState *s, uint16_t *srom)
|
||
|
|
{
|
||
|
|
- int word, n;
|
||
|
|
+ int word;
|
||
|
|
int bit;
|
||
|
|
unsigned char bitval, crc;
|
||
|
|
const int len = 9;
|
||
|
|
- n = 0;
|
||
|
|
crc = -1;
|
||
|
|
|
||
|
|
for (word = 0; word < len; word++) {
|
||
|
|
@@ -887,7 +886,6 @@ static void tulip_idblock_crc(TULIPState *s, uint16_t *srom)
|
||
|
|
srom[len - 1] = (srom[len - 1] & 0xff00) | (unsigned short)crc;
|
||
|
|
break;
|
||
|
|
}
|
||
|
|
- n++;
|
||
|
|
bitval = ((srom[word] >> bit) & 1) ^ ((crc >> 7) & 1);
|
||
|
|
crc = crc << 1;
|
||
|
|
if (bitval == 1) {
|
||
|
|
--
|
||
|
|
2.27.0
|
||
|
|
|