38 lines
1.6 KiB
Diff
38 lines
1.6 KiB
Diff
|
From f537178e29501b93349362bc46a0463550ff2206 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Alexander Bulekov <alxndr@bu.edu>
|
||
|
|
Date: Thu, 27 Apr 2023 17:10:08 -0400
|
||
|
|
Subject: [PATCH] checkpatch: add qemu_bh_new/aio_bh_new checks
|
||
|
|
|
||
|
|
Advise authors to use the _guarded versions of the APIs, instead.
|
||
|
|
|
||
|
|
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
|
||
|
|
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
|
||
|
|
Message-Id: <20230427211013.2994127-4-alxndr@bu.edu>
|
||
|
|
Signed-off-by: Thomas Huth <thuth@redhat.com>
|
||
|
|
---
|
||
|
|
scripts/checkpatch.pl | 8 ++++++++
|
||
|
|
1 file changed, 8 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
|
||
|
|
index cb8eff233e..b2428e80cc 100755
|
||
|
|
--- a/scripts/checkpatch.pl
|
||
|
|
+++ b/scripts/checkpatch.pl
|
||
|
|
@@ -2858,6 +2858,14 @@ sub process {
|
||
|
|
if ($line =~ /\bsignal\s*\(/ && !($line =~ /SIG_(?:IGN|DFL)/)) {
|
||
|
|
ERROR("use sigaction to establish signal handlers; signal is not portable\n" . $herecurr);
|
||
|
|
}
|
||
|
|
+# recommend qemu_bh_new_guarded instead of qemu_bh_new
|
||
|
|
+ if ($realfile =~ /.*\/hw\/.*/ && $line =~ /\bqemu_bh_new\s*\(/) {
|
||
|
|
+ ERROR("use qemu_bh_new_guarded() instead of qemu_bh_new() to avoid reentrancy problems\n" . $herecurr);
|
||
|
|
+ }
|
||
|
|
+# recommend aio_bh_new_guarded instead of aio_bh_new
|
||
|
|
+ if ($realfile =~ /.*\/hw\/.*/ && $line =~ /\baio_bh_new\s*\(/) {
|
||
|
|
+ ERROR("use aio_bh_new_guarded() instead of aio_bh_new() to avoid reentrancy problems\n" . $herecurr);
|
||
|
|
+ }
|
||
|
|
# check for module_init(), use category-specific init macros explicitly please
|
||
|
|
if ($line =~ /^module_init\s*\(/) {
|
||
|
|
ERROR("please use block_init(), type_init() etc. instead of module_init()\n" . $herecurr);
|
||
|
|
--
|
||
|
|
2.27.0
|
||
|
|
|