54 lines
1.9 KiB
Diff
54 lines
1.9 KiB
Diff
|
From 8c7bdb086c3417e73bcda56a317ca2586ccd2116 Mon Sep 17 00:00:00 2001
|
||
|
|
From: tangbinzy <tangbin_yewu@cmss.chinamobile.com>
|
||
|
|
Date: Sat, 12 Oct 2024 09:38:31 +0000
|
||
|
|
Subject: [PATCH] tests/unit/test-vmstate: Avoid dynamic stack allocation
|
||
|
|
mainline inclusion commit 972d325a8dc855aa3817d0df9e09fd556a0449f7 category:
|
||
|
|
bugfix
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
---------------------------------------------------------------
|
||
|
|
|
||
|
|
Use autofree heap allocation instead of variable-length
|
||
|
|
array on the stack.
|
||
|
|
|
||
|
|
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
|
||
|
|
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
|
||
|
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
||
|
|
Message-id: 20220819153931.3147384-12-peter.maydell@linaro.org
|
||
|
|
|
||
|
|
Signed-off-by: tangbinzy <tangbin_yewu@cmss.chinamobile.com>
|
||
|
|
---
|
||
|
|
tests/unit/test-vmstate.c | 7 +++----
|
||
|
|
1 file changed, 3 insertions(+), 4 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/tests/unit/test-vmstate.c b/tests/unit/test-vmstate.c
|
||
|
|
index ac47f0a44b..91879ad2d4 100644
|
||
|
|
--- a/tests/unit/test-vmstate.c
|
||
|
|
+++ b/tests/unit/test-vmstate.c
|
||
|
|
@@ -88,17 +88,16 @@ static void save_buffer(const uint8_t *buf, size_t buf_size)
|
||
|
|
static void compare_vmstate(const uint8_t *wire, size_t size)
|
||
|
|
{
|
||
|
|
QEMUFile *f = open_test_file(false);
|
||
|
|
- uint8_t result[size];
|
||
|
|
+ g_autofree uint8_t *result = g_malloc(size);
|
||
|
|
|
||
|
|
/* read back as binary */
|
||
|
|
|
||
|
|
- g_assert_cmpint(qemu_get_buffer(f, result, sizeof(result)), ==,
|
||
|
|
- sizeof(result));
|
||
|
|
+ g_assert_cmpint(qemu_get_buffer(f, result, size), ==, size);
|
||
|
|
g_assert(!qemu_file_get_error(f));
|
||
|
|
|
||
|
|
/* Compare that what is on the file is the same that what we
|
||
|
|
expected to be there */
|
||
|
|
- SUCCESS(memcmp(result, wire, sizeof(result)));
|
||
|
|
+ SUCCESS(memcmp(result, wire, size));
|
||
|
|
|
||
|
|
/* Must reach EOF */
|
||
|
|
qemu_get_byte(f);
|
||
|
|
--
|
||
|
|
2.41.0.windows.1
|
||
|
|
|