45 lines
1.6 KiB
Diff
45 lines
1.6 KiB
Diff
|
From 466653e339135572946a31d212205078854500da Mon Sep 17 00:00:00 2001
|
||
|
|
From: tangbinzy <tangbin_yewu@cmss.chinamobile.com>
|
||
|
|
Date: Wed, 13 Mar 2024 03:11:08 +0000
|
||
|
|
Subject: [PATCH] configure: Add missing POSIX-required space mainline
|
||
|
|
inclusion commit 35a7a6fc5624b1df828d82f2dfa74d0e4188b3b2 category: bugfix
|
||
|
|
|
||
|
|
---------------------------------------------------------------
|
||
|
|
|
||
|
|
In commit 7d7dbf9dc15be6e1 we added a line to the configure script
|
||
|
|
which is not valid POSIX shell syntax, because it is missing a space
|
||
|
|
after a '!' character. shellcheck diagnoses this:
|
||
|
|
|
||
|
|
if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then
|
||
|
|
^-- SC1035: You are missing a required space after the !.
|
||
|
|
|
||
|
|
and the OpenBSD shell will not correctly handle this without the space.
|
||
|
|
|
||
|
|
Fixes: 7d7dbf9dc15be6e1 ("configure: replace --enable/disable-git-update with --with-git-submodules")
|
||
|
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
||
|
|
Reviewed-by: Thomas Huth <thuth@redhat.com>
|
||
|
|
Tested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
|
||
|
|
Message-id: 20220720152631.450903-2-peter.maydell@linaro.org
|
||
|
|
|
||
|
|
Signed-off-by: tangbinzy <tangbin_yewu@cmss.chinamobile.com>
|
||
|
|
---
|
||
|
|
configure | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/configure b/configure
|
||
|
|
index d7a4502a8b..8c9abd0e6e 100755
|
||
|
|
--- a/configure
|
||
|
|
+++ b/configure
|
||
|
|
@@ -3337,7 +3337,7 @@ else
|
||
|
|
cxx=
|
||
|
|
fi
|
||
|
|
|
||
|
|
-if !(GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then
|
||
|
|
+if ! (GIT="$git" "$source_path/scripts/git-submodule.sh" "$git_submodules_action" "$git_submodules"); then
|
||
|
|
exit 1
|
||
|
|
fi
|
||
|
|
|
||
|
|
--
|
||
|
|
2.27.0
|
||
|
|
|