48 lines
1.6 KiB
Diff
48 lines
1.6 KiB
Diff
|
From 9949490829e5f4d0a0f3700025501e8cb5afc4d4 Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?=E5=BC=A0=E6=A5=9A=E5=90=9B?=
|
||
|
|
<zhangchujun@cmss.chinamobile.com>
|
||
|
|
Date: Tue, 24 Sep 2024 18:07:34 +0800
|
||
|
|
Subject: [PATCH] ui: remove break after g_assert_not_reached()
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
Use of assert(false) can trip spurious control flow warnings from
|
||
|
|
some versions of GCC (i.e. using -fsanitize=thread with gcc-12):
|
||
|
|
|
||
|
|
error: control reaches end of non-void function [-Werror=return-type]
|
||
|
|
default:
|
||
|
|
g_assert_not_reached();
|
||
|
|
break;
|
||
|
|
| ^^^^^
|
||
|
|
|
||
|
|
Solve that by removing the unreachable 'break' statement, unifying
|
||
|
|
the code base on g_assert_not_reached() instead.
|
||
|
|
|
||
|
|
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
|
||
|
|
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
|
||
|
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||
|
|
Message-ID: <20240910221606.1817478-37-pierrick.bouvier@linaro.org>
|
||
|
|
[PMD: Add description suggested by Eric Blake]
|
||
|
|
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
||
|
|
Signed-off-by: zhangchujun <zhangchujun@cmss.chinamobile.com>
|
||
|
|
---
|
||
|
|
ui/qemu-pixman.c | 1 -
|
||
|
|
1 file changed, 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/ui/qemu-pixman.c b/ui/qemu-pixman.c
|
||
|
|
index 3ab7e2e958..67a88bf8dd 100644
|
||
|
|
--- a/ui/qemu-pixman.c
|
||
|
|
+++ b/ui/qemu-pixman.c
|
||
|
|
@@ -48,7 +48,6 @@ PixelFormat qemu_pixelformat_from_pixman(pixman_format_code_t format)
|
||
|
|
break;
|
||
|
|
default:
|
||
|
|
g_assert_not_reached();
|
||
|
|
- break;
|
||
|
|
}
|
||
|
|
|
||
|
|
pf.amax = (1 << pf.abits) - 1;
|
||
|
|
--
|
||
|
|
2.41.0.windows.1
|
||
|
|
|