7bb77ea74f
- Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016).
- intel_iommu: Add missed sanity check for 256-bit invalidation queue
- linux-user: use 'max' instead of 'qemu32' / 'qemu64' by default
- chardev/baum: Use definitions to avoid dynamic stack allocation
- ui/console: Get tab completion working again in the SDL monitor vc
- s390x/tcg: Fix opcode for lzrf
- virtiofsd: use g_date_time_get_microsecond to get subsecond
- ui/curses: Avoid dynamic stack allocation
- target/m68k: always call gen_exit_tb() after writes to SR
- target/m68k: Perform writback before modifying SR
- target/m68k: Fix MACSR to CCR
- target/m68k: Implement atomic test-and-set
- block/nvme: nvme_process_completion() fix bound for cid
- hw/pci-host: pnv_phb{3, 4}: Fix heap out-of-bound access failure
- target/ppc: Zero second doubleword of VSR registers for FPR insns
- target/ppc: Set OV32 when OV is set
- target/ppc: Zero second doubleword for VSX madd instructions
- target/ppc: Set result to QNaN for DENBCD when VXCVI occurs
- hw/pci: Add parenthesis to PCI_BUILD_BDF macro
- intel_iommu: Send IQE event when setting reserved bit in IQT_TAIL
- acpi: cpuhp: fix guest-visible maximum access size to the legacy reg block
- acpi: ged: Add macro for acpi sleep control register
- hw/pci-bridge: Add a Kconfig switch for the normal PCI bridge
- ui/vnc: fix handling of VNC_FEATURE_XVP
- s390/sclp: fix SCLP facility map
- docs/tools/qemu-img.rst: fix typo (sumarizes)
- chardev/char: fix qemu_chr_is_busy() check
- edu: fix DMA range upper bound check
- platform-bus: fix refcount leak
- hw/net/virtio-net: fix qemu set used ring flag even vhost started
- hw/net/can/sja1000: fix bug for single acceptance filter and standard frame
- tests/avocado: fix typo in replay_linux
- util/userfaultfd: Remove unused uffd_poll_events
- hw/core/ptimer: fix timer zero period condition for freq > 1GHz
- hcd-ohci: Drop ohci_service_iso_td() if ed->head & OHCI_DPTR_MASK is zero
- tests/unit/test-vmstate: Avoid dynamic stack allocation
- hw/usb/hcd-ohci: Use definition to avoid dynamic stack allocation
- hw/i386/multiboot: Avoid dynamic stack allocation
- hw/ppc/spapr: Fix code style problems reported by checkpatch
- chardev/baum: Replace magic values by X_MAX / Y_MAX definitions
- hw/intc/xics: Avoid dynamic stack allocation
- hw/net/e1000e_core: Use definition to avoid dynamic stack allocation
- intel_iommu: Fix invalidation descriptor type field
- configs: Fix typo in the sh4-softmmu devices config file
Signed-off-by: Jiabo Feng <fengjiabo1@huawei.com>
(cherry picked from commit 9813ed21ec2499c50cb58ac5fb114a1641708eb2)
43 lines
1.5 KiB
Diff
43 lines
1.5 KiB
Diff
From ffb4abbc465b344d9e6195a9aac51e2530b13165 Mon Sep 17 00:00:00 2001
|
|
From: Zhang Jiao <zhangjiao2_yewu@cmss.chinamobile.com>
|
|
Date: Thu, 17 Oct 2024 13:14:54 +0800
|
|
Subject: [PATCH] platform-bus: fix refcount leak
|
|
|
|
cheery-pick from 99ec7b440a1d6a6ef07450b68687d24d13a25fb5
|
|
|
|
memory_region_find() returns an MR which it is the caller's
|
|
responsibility to unref, but platform_bus_map_mmio() was
|
|
forgetting to do so, thus leaking the MR.
|
|
|
|
Signed-off-by: Gao Shiyuan <gaoshiyuan@baidu.com>
|
|
Message-id: 20240829131005.9196-1-gaoshiyuan@baidu.com
|
|
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
|
|
[PMM: tweaked commit message]
|
|
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
|
|
Signed-off-by: Zhang Jiao <zhangjiao2_yewu@cmss.chinamobile.com>
|
|
---
|
|
hw/core/platform-bus.c | 5 ++++-
|
|
1 file changed, 4 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/hw/core/platform-bus.c b/hw/core/platform-bus.c
|
|
index b8487b26b6..dc58bf505a 100644
|
|
--- a/hw/core/platform-bus.c
|
|
+++ b/hw/core/platform-bus.c
|
|
@@ -145,9 +145,12 @@ static void platform_bus_map_mmio(PlatformBusDevice *pbus, SysBusDevice *sbdev,
|
|
* the target device's memory region
|
|
*/
|
|
for (off = 0; off < pbus->mmio_size; off += alignment) {
|
|
- if (!memory_region_find(&pbus->mmio, off, size).mr) {
|
|
+ MemoryRegion *mr = memory_region_find(&pbus->mmio, off, size).mr;
|
|
+ if (!mr) {
|
|
found_region = true;
|
|
break;
|
|
+ } else {
|
|
+ memory_region_unref(mr);
|
|
}
|
|
}
|
|
|
|
--
|
|
2.41.0.windows.1
|
|
|