7bb77ea74f
- Introduce the SM4 cipher algorithms (OSCCA GB/T 32907-2016).
- intel_iommu: Add missed sanity check for 256-bit invalidation queue
- linux-user: use 'max' instead of 'qemu32' / 'qemu64' by default
- chardev/baum: Use definitions to avoid dynamic stack allocation
- ui/console: Get tab completion working again in the SDL monitor vc
- s390x/tcg: Fix opcode for lzrf
- virtiofsd: use g_date_time_get_microsecond to get subsecond
- ui/curses: Avoid dynamic stack allocation
- target/m68k: always call gen_exit_tb() after writes to SR
- target/m68k: Perform writback before modifying SR
- target/m68k: Fix MACSR to CCR
- target/m68k: Implement atomic test-and-set
- block/nvme: nvme_process_completion() fix bound for cid
- hw/pci-host: pnv_phb{3, 4}: Fix heap out-of-bound access failure
- target/ppc: Zero second doubleword of VSR registers for FPR insns
- target/ppc: Set OV32 when OV is set
- target/ppc: Zero second doubleword for VSX madd instructions
- target/ppc: Set result to QNaN for DENBCD when VXCVI occurs
- hw/pci: Add parenthesis to PCI_BUILD_BDF macro
- intel_iommu: Send IQE event when setting reserved bit in IQT_TAIL
- acpi: cpuhp: fix guest-visible maximum access size to the legacy reg block
- acpi: ged: Add macro for acpi sleep control register
- hw/pci-bridge: Add a Kconfig switch for the normal PCI bridge
- ui/vnc: fix handling of VNC_FEATURE_XVP
- s390/sclp: fix SCLP facility map
- docs/tools/qemu-img.rst: fix typo (sumarizes)
- chardev/char: fix qemu_chr_is_busy() check
- edu: fix DMA range upper bound check
- platform-bus: fix refcount leak
- hw/net/virtio-net: fix qemu set used ring flag even vhost started
- hw/net/can/sja1000: fix bug for single acceptance filter and standard frame
- tests/avocado: fix typo in replay_linux
- util/userfaultfd: Remove unused uffd_poll_events
- hw/core/ptimer: fix timer zero period condition for freq > 1GHz
- hcd-ohci: Drop ohci_service_iso_td() if ed->head & OHCI_DPTR_MASK is zero
- tests/unit/test-vmstate: Avoid dynamic stack allocation
- hw/usb/hcd-ohci: Use definition to avoid dynamic stack allocation
- hw/i386/multiboot: Avoid dynamic stack allocation
- hw/ppc/spapr: Fix code style problems reported by checkpatch
- chardev/baum: Replace magic values by X_MAX / Y_MAX definitions
- hw/intc/xics: Avoid dynamic stack allocation
- hw/net/e1000e_core: Use definition to avoid dynamic stack allocation
- intel_iommu: Fix invalidation descriptor type field
- configs: Fix typo in the sh4-softmmu devices config file
Signed-off-by: Jiabo Feng <fengjiabo1@huawei.com>
(cherry picked from commit 9813ed21ec2499c50cb58ac5fb114a1641708eb2)
53 lines
2.0 KiB
Diff
53 lines
2.0 KiB
Diff
From cf7f716ba8fbcc4fc4d4edcce7bc3c6bbfa425a5 Mon Sep 17 00:00:00 2001
|
|
From: tangzhongrui <tangzhongrui@cmss.chinamobile.com>
|
|
Date: Wed, 6 Nov 2024 15:02:38 +0800
|
|
Subject: [PATCH] hw/pci: Add parenthesis to PCI_BUILD_BDF macro
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
The bus parameter in the macro PCI_BUILD_BDF is not surrounded by
|
|
parenthesis. This can create a compile error when warnings are
|
|
treated as errors or can potentially create runtime errors due to the
|
|
operator precedence.
|
|
|
|
For instance:
|
|
|
|
file.c:x:32: error: suggest parentheses around '-' inside '<<'
|
|
[-Werror=parentheses]
|
|
171 | uint16_t bdf = PCI_BUILD_BDF(a - b, sdev->devfn);
|
|
| ~~^~~
|
|
include/hw/pci/pci.h:19:41: note: in definition of macro
|
|
'PCI_BUILD_BDF'
|
|
19 | #define PCI_BUILD_BDF(bus, devfn) ((bus << 8) | (devfn))
|
|
| ^~~
|
|
cc1: all warnings being treated as errors
|
|
|
|
Signed-off-by: Roque Arcudia Hernandez <roqueh@google.com>
|
|
Reviewed-by: Nabih Estefan <nabihestefan@google.com>
|
|
Message-Id: <20241101215923.3399311-1-roqueh@google.com>
|
|
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
|
Signed-off-by: Zhongrui Tang <tangzhongrui_yewu@cmss.chinamobile.com>
|
|
---
|
|
include/hw/pci/pci.h | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
|
|
index 458126a18c..a0cf893bfd 100644
|
|
--- a/include/hw/pci/pci.h
|
|
+++ b/include/hw/pci/pci.h
|
|
@@ -18,7 +18,7 @@ extern bool pci_available;
|
|
#define PCI_BUS_NUM(x) (((x) >> 8) & 0xff)
|
|
#define PCI_SLOT(devfn) (((devfn) >> 3) & 0x1f)
|
|
#define PCI_FUNC(devfn) ((devfn) & 0x07)
|
|
-#define PCI_BUILD_BDF(bus, devfn) ((bus << 8) | (devfn))
|
|
+#define PCI_BUILD_BDF(bus, devfn) (((bus) << 8) | (devfn))
|
|
#define PCI_BUS_MAX 256
|
|
#define PCI_DEVFN_MAX 256
|
|
#define PCI_SLOT_MAX 32
|
|
--
|
|
2.41.0.windows.1
|
|
|