f4f53a5098
- hw/nvme: Remove redundant dma_blk_write - tests/avocado/machine_s390_ccw_virtio: Adapt test to new default resolution - edid: set default resolution to 1280x800 (WXGA) - iotests/308: Fix for CAP_DAC_OVERRIDE - hvf: remove unused but set variable - vvfat: Fix vvfat_write() for writes before the root directory - hw/misc/nrf51_rng: Don't use BIT_MASK() when we mean BIT() - hw/pci: Remove unused pci_irq_pulse() method - ui/gtk: fix leaks found wtih fuzzing - target/i386: fix size of EBP writeback in gen_enter() - tests/qtest/fuzz: fix memleak in qos_fuzz.c - hw/core/loader: gunzip(): fix memory leak on error path - migration: fix a typo - scsi: fetch unit attention when creating the request - raw-format: Fix error message for invalid offset/size - tcg: Reset data_gen_ptr correctly - Fix calculation of minimum in colo_compare_tcp - hw/intc: Don't clear pending bits on IRQ lowering - target/arm: Drop user-only special case in sve_stN_r - usb-hub: Fix handling port power control messages - target/ppc: Set ctx->opcode for decode_insn32() - linux-user: Add proper strace format strings for getdents()/getdents64() - linux-user: Fix TARGET_PROT_SEM for XTENSA - linux-user/hppa: Set TASK_UNMAPPED_BASE to 0xfa000000 for hppa arch - linux-user/hppa: Dump IIR on register dump - tests: Fix typo in check-help output - qdev-core.h: Fix wrongly named reference to TYPE_SPLIT_IRQ - hw/scsi/megasas: Simplify using the ldst API - gqa-win: get_pci_info: Clean dev_info if handle is valid - target/ppc: Fix 7448 support - vvfat: Fix size of temporary qcow file - docs: Correct 'vhost-user-blk' spelling - jackaudio: use ifdefs to hide unavailable functions - simplebench: Fix Python syntax error (reported by LGTM) - python: update type hints for mypy 0.930 - Python/aqmp: fix type definitions for mypy 0.920 - tcg: Allow top bit of SIMD_DATA_BITS to be set in simd_desc() - hw/ppc/e500: Prefer QOM cast - hw/ppc/e500: Remove unused "irqs" parameter - hw/ppc/e500: Add missing device tree properties to i2c controller node - linux-user: Show timespec on strace for futex() - linux-user: Add strace for clock_nanosleep() - linux-user: Fix strace of chmod() if mode == 0 - linux-user: Log failing executable in EXCP_DUMP() - linux-user: Add pidfd_open(), pidfd_send_signal() and pidfd_getfd() syscalls Signed-off-by: Jiabo Feng <fengjiabo1@huawei.com> (cherry picked from commit 87ebac5b5cfb97ddb7ac2af097703758fb0751c4)
53 lines
1.8 KiB
Diff
53 lines
1.8 KiB
Diff
From 1876a69642964cdaadcce4dd797c0b91f02c2ed3 Mon Sep 17 00:00:00 2001
|
|
From: Zhang Jiao <zhangjiao2_yewu@cmss.chinamobile.com>
|
|
Date: Thu, 12 Dec 2024 09:57:44 +0800
|
|
Subject: [PATCH] ui/gtk: fix leaks found wtih fuzzing
|
|
|
|
cheery-pick from e38f4e976dd40c985bfe84230a627de9a108c9d3
|
|
|
|
It is true, that there is no problem during runtime
|
|
from the first sight, because the memory is lost just
|
|
before qemu exits. Nevertheless, this change is necessary,
|
|
because AddressSanitizer is not able to recognize this
|
|
situation and produces crash-report (which is
|
|
false-positive in fact). Lots of False-Positive warnings
|
|
are davaluing problems, found with fuzzing, and thus the
|
|
whole methodology of dynamic analysis.
|
|
This patch eliminates such False-Positive reports,
|
|
and makes every problem, found with fuzzing, more valuable.
|
|
|
|
Fixes: 060ab76356 ("gtk: don't exit early in case gtk init fails")
|
|
|
|
Signed-off-by: Dmitry Frolov <frolov@swemel.ru>
|
|
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
|
|
Message-Id: <20230825115818.1091936-1-frolov@swemel.ru>
|
|
Signed-off-by: Zhang Jiao <zhangjiao2_yewu@cmss.chinamobile.com>
|
|
---
|
|
ui/gtk.c | 3 ++-
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/ui/gtk.c b/ui/gtk.c
|
|
index 6d9cb42b3d..f16ccf9c4b 100644
|
|
--- a/ui/gtk.c
|
|
+++ b/ui/gtk.c
|
|
@@ -2245,7 +2245,7 @@ static void gtk_display_init(DisplayState *ds, DisplayOptions *opts)
|
|
{
|
|
VirtualConsole *vc;
|
|
|
|
- GtkDisplayState *s = g_malloc0(sizeof(*s));
|
|
+ GtkDisplayState *s;
|
|
GdkDisplay *window_display;
|
|
GtkIconTheme *theme;
|
|
char *dir;
|
|
@@ -2255,6 +2255,7 @@ static void gtk_display_init(DisplayState *ds, DisplayOptions *opts)
|
|
exit(1);
|
|
}
|
|
assert(opts->type == DISPLAY_TYPE_GTK);
|
|
+ s = g_malloc0(sizeof(*s));
|
|
s->opts = opts;
|
|
|
|
theme = gtk_icon_theme_get_default();
|
|
--
|
|
2.41.0.windows.1
|
|
|