ab7fc8ee5b
- target/i386: Introduce SapphireRapids-v3 to add missing features - qtest/fuzz-lsi53c895a-test: set guest RAM to 2G - hw/net/lan9118: Signal TSFL_INT flag when TX FIFO reaches specified level - target/arm: Fix alignment for VLD4.32 - hw/microblaze: pass random seed to fdt - tests/qtest: npcm7xx-emc-test: Skip checking MAC - tests: mark io-command test as skipped if socat is missing - tests: unit: add NULL-pointer check - tests: test-qga: close socket on failure to connect - vdpa:block device capacity expansion online support vdpa block device update capacity. - virtio-net: Ensure queue index fits with RSS(CVE-2024-6505) - nbd/server: CVE-2024-7409: Avoid use-after-free when closing server - ppc/vof: Fix unaligned FDT property access - vvfat: Fix reading files with non-continuous clusters - vvfat: Fix bug in writing to middle of file - savevm: Fix load_snapshot error path crash - hw/dma/xilinx_axidma: Use semicolon at end of statement, not comma - hw/remote/message.c: Don't directly invoke DeviceClass:reset - crypto/tlscredspsk: Free username on finalize - hw/display/vhost-user-gpu.c: fix vhost_user_gpu_chr_read() - virtio: remove virtio_tswap16s() call in vring_packed_event_read() - char-stdio: Restore blocking mode of stdout on exit - hw/ppc: spapr: Use qemu_vfree() to free spapr->htab - smbios: sanitize type from external type before checking have_fields_bitmap - spapr_pci: fix leak in spapr_phb_vfio_get_loc_code - KVM: use store-release to mark dirty pages as harvested - monitor/hmp: print trace as option in help for log command - tpm_crb: Avoid backend startup just before shutdown under Xen - crypto/block-luks: make range overlap check more readable - spapr: Free stdout path - target/rx: Use target_ulong for address in LI - virtio-pci: Fix the use of an uninitialized irqfd - rtl8139: Fix behaviour for old kernels. - virtio-rng: block max-bytes=0 MIME-Version: 1.0 - hw/audio/es1370: Clean up comment - vhost-user-server: do not set memory fd non-blocking - ui: reject extended clipboard message if not activated - virtio-net: Fix vhost virtqueue notifiers for RSS - hw/misc/applesmc: Fix memory leak in reset() handler Signed-off-by: Jiabo Feng <fengjiabo1@huawei.com> (cherry picked from commit db7a5d9a7239db307c8c1454fab5f8a92fd486b8)
40 lines
1.4 KiB
Diff
40 lines
1.4 KiB
Diff
From f2f914e1868a83ffef1580465988557df0257bc6 Mon Sep 17 00:00:00 2001
|
|
From: tangbinzy <tangbin_yewu@cmss.chinamobile.com>
|
|
Date: Mon, 9 Sep 2024 07:54:12 +0000
|
|
Subject: [PATCH] tests: unit: add NULL-pointer check mainline inclusion commit
|
|
b3a58a6ae346f14075af0df7f9903ad389c33dbd category: bugfix
|
|
|
|
---------------------------------------------------------------
|
|
|
|
In CID 1432593, Coverity complains that the result of qdict_crumple()
|
|
might leak if it is not a dictionary. This is not a practical concern
|
|
since the test would fail immediately with a NULL pointer dereference
|
|
in qdict_size().
|
|
|
|
However, it is not nice to depend on qdict_size() crashing, so add an
|
|
explicit assertion that that the crumpled object was indeed a dictionary.
|
|
|
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
|
|
Signed-off-by: tangbinzy <tangbin_yewu@cmss.chinamobile.com>
|
|
---
|
|
tests/unit/check-block-qdict.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/tests/unit/check-block-qdict.c b/tests/unit/check-block-qdict.c
|
|
index 5a25825093..751c58e737 100644
|
|
--- a/tests/unit/check-block-qdict.c
|
|
+++ b/tests/unit/check-block-qdict.c
|
|
@@ -504,7 +504,7 @@ static void qdict_crumple_test_empty(void)
|
|
src = qdict_new();
|
|
|
|
dst = qobject_to(QDict, qdict_crumple(src, &error_abort));
|
|
-
|
|
+ g_assert(dst);
|
|
g_assert_cmpint(qdict_size(dst), ==, 0);
|
|
|
|
qobject_unref(src);
|
|
--
|
|
2.41.0.windows.1
|
|
|