11aadaf893
- python/aqmp: use absolute import statement - sysemu: Cleanup qemu_run_machine_init_done_notifiers() - vhost-backend: avoid overflow on memslots_limit - hw/i386/vmmouse: Require 'i8042' property to be set - hw/scsi/megasas: Fails command if SGL buffer overflows - target/i386/kvm: Replace use of __u32 type - hw/avr: Realize AVRCPU qdev object using qdev_realize() - qemu-keymap: Add license in generated files - configure: Symlink binaries using .exe suffix with MinGW - ui: remove break after g_assert_not_reached() - io/channel-websock: Replace strlen(const_str) by sizeof(const_str) - 1 - target/ppc: Add HASHKEYR and HASHPKEYR SPRs - tests: Fix error strings - Hexagon (target/hexagon) remove unused encodings - target/i386: introduce insn_get_addr - target/i386: REPZ and REPNZ are mutually exclusive - target/i386: correctly mask SSE4a bit indices in register operands - bios-tables-test: Make oem-fields tests be consistent - tests/vm: update NetBSD to 9.3 - monitor/hmp-cmds: Avoid displaying bogus size in 'info pci' When BAR aren't mapped, we get: - virtio-mem: don't warn about THP sizes on a kernel without THP Support - Subject: [PATCH] kvm: Use 'unsigned long' for request argument in functions wrapping ioctl() Signed-off-by: Jiabo Feng <fengjiabo1@huawei.com> (cherry picked from commit 2430c96ac522f910c11eb98c2d9f74c2c3336a00)
74 lines
2.2 KiB
Diff
74 lines
2.2 KiB
Diff
From 45e03e38593db8583788a53f08735199f203a370 Mon Sep 17 00:00:00 2001
|
|
From: liujing <liujing_yewu@cmss.chinamobile.com>
|
|
Date: Wed, 18 Sep 2024 17:54:50 +0800
|
|
Subject: [PATCH] target/i386: introduce insn_get_addr
|
|
|
|
The "O" operand type in the Intel SDM needs to load an 8- to 64-bit
|
|
unsigned value, while insn_get is limited to 32 bits. Extract the code
|
|
out of disas_insn and into a separate function.
|
|
|
|
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
|
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
|
Signed-off-by: Liu Jing <liujing_yewu@cmss.chinamobile.com>
|
|
---
|
|
target/i386/tcg/translate.c | 36 ++++++++++++++++++++++++++----------
|
|
1 file changed, 26 insertions(+), 10 deletions(-)
|
|
|
|
diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
|
|
index 82f77b52fb..44cea102eb 100644
|
|
--- a/target/i386/tcg/translate.c
|
|
+++ b/target/i386/tcg/translate.c
|
|
@@ -2282,6 +2282,31 @@ static void gen_ldst_modrm(CPUX86State *env, DisasContext *s, int modrm,
|
|
}
|
|
}
|
|
|
|
+static target_ulong insn_get_addr(CPUX86State *env, DisasContext *s, MemOp ot)
|
|
+{
|
|
+ target_ulong ret;
|
|
+
|
|
+ switch (ot) {
|
|
+ case MO_8:
|
|
+ ret = x86_ldub_code(env, s);
|
|
+ break;
|
|
+ case MO_16:
|
|
+ ret = x86_lduw_code(env, s);
|
|
+ break;
|
|
+ case MO_32:
|
|
+ ret = x86_ldl_code(env, s);
|
|
+ break;
|
|
+#ifdef TARGET_X86_64
|
|
+ case MO_64:
|
|
+ ret = x86_ldq_code(env, s);
|
|
+ break;
|
|
+#endif
|
|
+ default:
|
|
+ g_assert_not_reached();
|
|
+ }
|
|
+ return ret;
|
|
+}
|
|
+
|
|
static inline uint32_t insn_get(CPUX86State *env, DisasContext *s, MemOp ot)
|
|
{
|
|
uint32_t ret;
|
|
@@ -5703,16 +5728,7 @@ static target_ulong disas_insn(DisasContext *s, CPUState *cpu)
|
|
target_ulong offset_addr;
|
|
|
|
ot = mo_b_d(b, dflag);
|
|
- switch (s->aflag) {
|
|
-#ifdef TARGET_X86_64
|
|
- case MO_64:
|
|
- offset_addr = x86_ldq_code(env, s);
|
|
- break;
|
|
-#endif
|
|
- default:
|
|
- offset_addr = insn_get(env, s, s->aflag);
|
|
- break;
|
|
- }
|
|
+ offset_addr = insn_get_addr(env, s, s->aflag);
|
|
tcg_gen_movi_tl(s->A0, offset_addr);
|
|
gen_add_A0_ds_seg(s);
|
|
if ((b & 2) == 0) {
|
|
--
|
|
2.41.0.windows.1
|
|
|