77 lines
3.5 KiB
Diff
77 lines
3.5 KiB
Diff
From cc2030f928981947db8fb9ec185a82024abab2c4 Mon Sep 17 00:00:00 2001
|
|
From: xujing <xujing125@huawei.com>
|
|
Date: Wed, 16 Oct 2024 15:19:09 +0800
|
|
Subject: [PATCH] pid1: add env var to override default mount rate limit
|
|
interval
|
|
|
|
Similar to 24a4542c. 24a4542c can only be set 1 in 1s at most,
|
|
sometimes we may need to set to something else(such as 1 in 2s).
|
|
So it's best to let the user decide.
|
|
|
|
This also allows users to solve #34690.
|
|
|
|
Signed-off-by: xujing <xujing125@huawei.com>
|
|
---
|
|
docs/ENVIRONMENT.md | 7 +++++++
|
|
src/core/mount.c | 14 +++++++++++---
|
|
2 files changed, 18 insertions(+), 3 deletions(-)
|
|
|
|
diff --git a/docs/ENVIRONMENT.md b/docs/ENVIRONMENT.md
|
|
index 4c37e03..0796eae 100644
|
|
--- a/docs/ENVIRONMENT.md
|
|
+++ b/docs/ENVIRONMENT.md
|
|
@@ -270,6 +270,13 @@ All tools:
|
|
default is not appropriate for a given system. Defaults to `5`, accepts
|
|
positive integers.
|
|
|
|
+* `$SYSTEMD_DEFAULT_MOUNT_RATE_LIMIT_INTERVAL_SEC` — can be set to override the mount
|
|
+ units interval rate limit for parsing `/proc/self/mountinfo`. Similar to
|
|
+ `$SYSTEMD_DEFAULT_MOUNT_RATE_LIMIT_BURST`, the interval limit maybe adjusted when
|
|
+ the default is not appropriate for a given system. The default value is 1 and the
|
|
+ default application time unit is second, and the time unit can beoverriden as usual
|
|
+ by specifying it explicitly, see the systemd.time(7) man page.
|
|
+
|
|
* `$SYSTEMD_REMOUNT_ROOT_RW=1` — if set and no entry for the root directory
|
|
exists in `/etc/fstab` (this file always takes precedence), then the root
|
|
directory is remounted writable. This is primarily used by
|
|
diff --git a/src/core/mount.c b/src/core/mount.c
|
|
index ead9b46..f4bc6eb 100644
|
|
--- a/src/core/mount.c
|
|
+++ b/src/core/mount.c
|
|
@@ -1875,6 +1875,7 @@ static void mount_enumerate(Manager *m) {
|
|
mnt_init_debug(0);
|
|
|
|
if (!m->mount_monitor) {
|
|
+ usec_t mount_rate_limit_interval = 1 * USEC_PER_SEC;
|
|
unsigned mount_rate_limit_burst = 5;
|
|
int fd;
|
|
|
|
@@ -1916,14 +1917,21 @@ static void mount_enumerate(Manager *m) {
|
|
}
|
|
|
|
/* Let users override the default (5 in 1s), as it stalls the boot sequence on busy systems. */
|
|
- const char *e = secure_getenv("SYSTEMD_DEFAULT_MOUNT_RATE_LIMIT_BURST");
|
|
+ const char *e = secure_getenv("SYSTEMD_DEFAULT_MOUNT_RATE_LIMIT_INTERVAL_SEC");
|
|
+ if (e) {
|
|
+ r = parse_sec(e, &mount_rate_limit_interval);
|
|
+ if (r < 0)
|
|
+ log_debug_errno(r, "Invalid value in $SYSTEMD_DEFAULT_MOUNT_RATE_LIMIT_INTERVAL_SEC, ignoring: %s", e);
|
|
+ }
|
|
+
|
|
+ e = secure_getenv("SYSTEMD_DEFAULT_MOUNT_RATE_LIMIT_BURST");
|
|
if (e) {
|
|
r = safe_atou(e, &mount_rate_limit_burst);
|
|
if (r < 0)
|
|
- log_debug("Invalid value in $SYSTEMD_DEFAULT_MOUNT_RATE_LIMIT_BURST, ignoring: %s", e);
|
|
+ log_debug_errno(r, "Invalid value in $SYSTEMD_DEFAULT_MOUNT_RATE_LIMIT_BURST, ignoring: %s", e);
|
|
}
|
|
|
|
- r = sd_event_source_set_ratelimit(m->mount_event_source, 1 * USEC_PER_SEC, mount_rate_limit_burst);
|
|
+ r = sd_event_source_set_ratelimit(m->mount_event_source, mount_rate_limit_interval, mount_rate_limit_burst);
|
|
if (r < 0) {
|
|
log_error_errno(r, "Failed to enable rate limit for mount events: %m");
|
|
goto fail;
|
|
--
|
|
2.33.0
|
|
|